Skip to content

De-abstract Savable by making it a protocol#298

Closed
unkcpz wants to merge 47 commits intoaiidateam:masterfrom
unkcpz:deab-savable-inh
Closed

De-abstract Savable by making it a protocol#298
unkcpz wants to merge 47 commits intoaiidateam:masterfrom
unkcpz:deab-savable-inh

Conversation

@unkcpz
Copy link
Member

@unkcpz unkcpz commented Dec 12, 2024 •
edited
Loading

The outcome of this refactoring is that the Savable become a protocol which provide the contract for how things needed to be saved should implemented.

@runtime_checkable
class Savable(Protocol):
    @classmethod
    def recreate_from(cls, saved_state: SAVED_STATE_TYPE, load_context: LoadSaveContext | None = None) -> 'Savable':
        """
        Recreate a :class:`Savable` from a saved state using an optional load context.

        :param saved_state: The saved state
        :param load_context: An optional load context

        :return: The recreated instance

        """
        ...

    def save(self, save_context: LoadSaveContext | None = None) -> SAVED_STATE_TYPE: ...

Compare to the original implementation where save calls save_instance_state calls each other recursively until all savable things is saved, the new implementation force the save method independent and have symmetry behavior of recreate_from.

unkcpz#5

@unkcpz unkcpz marked this pull request as draft December 12, 2024 11:04
@unkcpz unkcpz force-pushed the deab-savable-inh branch 5 times, most recently from 34d9b01 to d524e63 Compare January 18, 2025 01:59
@unkcpz unkcpz changed the base branch from dev to master January 18, 2025 02:04
@unkcpz unkcpz force-pushed the deab-savable-inh branch 2 times, most recently from e149bd2 to a90dcff Compare January 22, 2025 10:04
unkcpz added 19 commits February 5, 2025 15:20
@unkcpz
Use uv.lock
c86e502
@unkcpz
Defer import of aio_pika
5980bd6
@unkcpz
Explicit future implementation: distinguish concurrent.future.Future …
827d5c8 
…and asyncio.Future

hand write wrap to kiwipy future (concurrent.futures.Future)

kiwipy.Future -> concurrent.futures.Future
@unkcpz
Move communication into rmq module
cf58970 
Move communication to rmq
@unkcpz
Move TaskRejectError as the common exception for task launch
307514c
@unkcpz
Remove useless communicator param passed to ProcessLaunch __call__
3ef6bd8
@unkcpz
Forming Communicator protocol
3536f29
@unkcpz
Remove kiwipy/rmq dependencies of process module
ee0da23
@unkcpz
Interface change from communicator -> coordinator
7f5e7ce
@unkcpz
Remove unnecessary task_send ab from RemoteProcessControl interface
229747c
@unkcpz
Interface for ProcessController
758fa3b
@unkcpz
RmqCoordinator example to show how using interface can avoid making c…
e9b1da6 
…hange in kiwipy
@unkcpz
broadcast subscriber has versatile filters
b564a0f
@unkcpz
Generic typing for Coordinator
df92da4
@unkcpz
changes required for aiida-core support
3872dc3
@unkcpz
Adopt new message protocol
c5ce865
@unkcpz
Simpler create_task_threadsafe implementation
68f7409
@unkcpz
Remove RmqCoordinator to tests/util only
60bfdab
@unkcpz
Export plumpy.futures.Future
21c8157
unkcpz and others added 19 commits February 5, 2025 15:26
@unkcpz
Move is_terminal as class attribute required
a684daf
@unkcpz
forming the enter/exit for State protocol
f023e9c
@unkcpz
Forming Interruptable and Proceedable protocol
50d7f65
@unkcpz
Refactoring create_state as static function initialize state from label
a111cd8 
create_state refact

Hashable initialized + parameters passed to Hashable

Fix pre-commit errors
@unkcpz
To lenthy for rethinking
11f7518
@unkcpz
Move static method load outside
da45d60
@unkcpz
save_instance_state simplify to only has save interface
3993e4c 
For the auto_persist attributes, the fn auto_save will take care of save
the state
@unkcpz
load_instance_state deabstract simplify
dab66cc 
- stepper de-abstract
- remove ContextMixin
- Stepper all using recreate_from
@unkcpz
ProcessListener recreate_from
4bf5e99
@unkcpz
Absorb all load_instance_state into recreate_from
cc80a0b
@unkcpz
Remove useless persist method of Savable class
efb322b
@unkcpz
Explicity recreate_from implementation
94590a6
@unkcpz
forming Savable protocol
90848fa 
- remove persist_config flag of savable
@unkcpz
Make auto_load symmetry with auto_save and state/state_label distinguish
d5680d7
@unkcpz
misc rebase
4195247
@unkcpz
debug logger when state change
4f6a2bb
@unkcpz
logger for load process from context
15ce0fe
@unkcpz
Using typing-extensions for 3.9 support of @OverRide
845a7d6
@unkcpz
Move BroadcastFilter from kiwipy into plumpy and used directly (#34)
b485d7d
@unkcpz
Copy link
Member Author

unkcpz commented Oct 13, 2025

Not planed anymore.

@unkcpz unkcpz closed this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@unkcpz